Skip to content

[Lens] Fix flaky test by closing options after use#64714

Merged
wylieconlon merged 2 commits intoelastic:masterfrom
wylieconlon:lens/fix-flaky-test
Apr 29, 2020
Merged

[Lens] Fix flaky test by closing options after use#64714
wylieconlon merged 2 commits intoelastic:masterfrom
wylieconlon:lens/fix-flaky-test

Conversation

@wylieconlon
Copy link
Copy Markdown
Contributor

Fixes flakiness found by @spalger and @restrry in #64685 and #64414

Checklist

@wylieconlon wylieconlon added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.8.0 labels Apr 28, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wylieconlon
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon wylieconlon merged commit af2e86f into elastic:master Apr 29, 2020
@wylieconlon wylieconlon deleted the lens/fix-flaky-test branch April 29, 2020 14:50
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Apr 29, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
wylieconlon pushed a commit that referenced this pull request Apr 29, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants